Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month dropdown does not show all months #452

Closed
Gelo93 opened this issue Sep 18, 2018 · 7 comments · Fixed by #455
Closed

Month dropdown does not show all months #452

Gelo93 opened this issue Sep 18, 2018 · 7 comments · Fixed by #455
Labels
Status: done Type: regression Valid bug in a previously working feature, confirmed by a contributor.

Comments

@Gelo93
Copy link

Gelo93 commented Sep 18, 2018

I have updated to the newest version of the daterange picker and have noticed something different from previous versions.
When clicking on month dropdown, I am given only the previous months and cannot select any further months, image attached.
screen shot 2018-09-18 at 10 40 51

Thank you

@Gelo93
Copy link
Author

Gelo93 commented Sep 19, 2018

Link to Fiddle: https://jsfiddle.net/smz18vyw/13/

@monovertex
Copy link
Collaborator

Thanks for reporting this bug, @Gelo93. I confirmed it, we'll take a look at it.

@monovertex monovertex changed the title Month Dropdown does not show all months. Month Dropdown does not show all months Sep 19, 2018
@monovertex monovertex added Type: regression Valid bug in a previously working feature, confirmed by a contributor. Status: todo Accepted issue that needs someone to fix it. Category: help wanted Good issue for beginners. labels Sep 19, 2018
@monovertex monovertex changed the title Month Dropdown does not show all months Month dropdown does not show all months Sep 19, 2018
@Gelo93
Copy link
Author

Gelo93 commented Sep 20, 2018

Updated PR without the formatting changes here, @monovertex

@monovertex
Copy link
Collaborator

@Gelo93, please see #455 and let me know if it fixes your issue. You can test the fixed version in this jsfiddle.

@Gelo93
Copy link
Author

Gelo93 commented Sep 23, 2018

Hi @monovertex, it shows the correct dates on dropdown now, but the wrong month is shown to have a tick next to it. As shown in the screenshot, the months showing on the date range are August and September, but January is shown to have a tick next to it.
screen shot 2018-09-23 at 10 43 00

Thanks

@monovertex
Copy link
Collaborator

@Gelo93, thanks for the help! I missed that bug. Please see this new version. The bug should be now fixed and the un-selectable options should be handled more graciously.

@Gelo93
Copy link
Author

Gelo93 commented Sep 24, 2018

@monovertex Thank you, that is working perfectly now

monovertex added a commit that referenced this issue Sep 26, 2018
…ent-month-when-generating-month-select

Bugfix/#412, #452 - Fix out-of-bounds options when building the month/year selects
@monovertex monovertex added Status: done and removed Status: todo Accepted issue that needs someone to fix it. Category: help wanted Good issue for beginners. labels Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: done Type: regression Valid bug in a previously working feature, confirmed by a contributor.
Projects
None yet
2 participants