Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials for TileWMS #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MTD-Thomas
Copy link

@MTD-Thomas MTD-Thomas commented Jan 17, 2025

Add a new property on Layer called Credentials to set the header Authorization during tile calls

In interop Javascript, only for TileWMS, I set tileLoadFunction to use these credentials if defined

Closes #105

@lolochristen
Copy link
Owner

Thanks a lot for you PR. I like your approach. I will review asap with some comments/suggestions.

@MTD-Thomas
Copy link
Author

I will probably need later a different way to transfer credentials, right now I only managed Basic authentication but later I will probably need to implement Bearer.

So when the time comes I will improve this code

@MTD-Thomas
Copy link
Author

We probably could merge every cases by creating a property AuthorizationHeader instead of Credentials which will contains both Bearer or Basic followed by the value and use this whole property to define the header in the query

Tell me if you want me to change my code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define credentials for TileWMS
2 participants