Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabindex toggles from -1 to 0 for a11y #78

Merged
merged 1 commit into from
May 10, 2018

Conversation

ReWWeR
Copy link
Contributor

@ReWWeR ReWWeR commented Apr 27, 2018

When first or last page is selected then 'next','prev','first page' and 'last page' buttons should be disabled and tabindex should be -1, to prevent focusing the elements via tabulation

…equirements for not focusing disabled buttons)
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   79.59%   79.59%           
=======================================
  Files           1        1           
  Lines          49       49           
  Branches       12       12           
=======================================
  Hits           39       39           
  Misses          7        7           
  Partials        3        3
Impacted Files Coverage Δ
src/components/Paginate.vue 79.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee27da1...8a4fd3c. Read the comment docs.

@lokyoung
Copy link
Owner

@ReWWeR That's correct. Thanks.

@lokyoung lokyoung closed this May 10, 2018
@lokyoung lokyoung reopened this May 10, 2018
@lokyoung lokyoung merged commit 8448f14 into lokyoung:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants