Accessibility improvements to fix errors identified by wave.webaim.org #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elohanlon
commented
Feb 17, 2019
elohanlon
commented
- Add alt attribute to .lb-image
tag
- Add aria-label attribute to .lb-prev and .lb-next tags
- Add alt attribute to .lb-image <img> tag - Add aria-label attribute to .lb-prev and .lb-next <a> tags
elohanlon
force-pushed
the
accessibility-improvement
branch
from
1043659
to
934e47c
Compare
|
Merge conflict on this PR now. But I moved your fix to a new PR: #651 Thank you. Attributed your report and fix in the PR. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.