Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added embed video feature #564

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

peppertom
Copy link

No description provided.

@miyagisan221b
Copy link

This works pretty well, except the play button (YouTube) isn't really clickable without some real precision. Example: https://www.screencast.com/t/B2Ha5SHj

@peppertom
Copy link
Author

peppertom commented Feb 8, 2017

Thanks @miyagisan85, I really appreciate Your comment!

Actually my latest commit (02f0d6e) is about fixing the border (box-sizing) and in update navigation styles over video (d66b03d) I updated the video navigation so that the video could easily be controlled.

Please find my gif in which I highlight the nav areas and the YouTube play button.

http://i.imgur.com/q9dJS1V.gifv

@miyagisan221b
Copy link

Ahh - it appears I downloaded the wrong version. I must have had a moment and thought the latest commit was at the top. Good show @peppertom, it appears to be working perfectly now. Hopefully this is merged in with the main project soon.

@peppertom
Copy link
Author

thanks @miyagisan85

@Luc45
Copy link

Luc45 commented Jan 27, 2019

Hi @lokesh, any plans for merging this? Video support would be a great addition to the library.

@lokesh
Copy link
Owner

lokesh commented Apr 21, 2019

No plans to merge this in to Lightbox v2 as the project is in maintenance mode and I'm not making significant changes besides fixing bugs. I do appreciate the PRs and hopefully people can pick through the code they need in their personal fork.

I am considering video support for the next major release but that is still in brainstorming mode and without a timeline.

@awannawa
Copy link

thankyou verry much for adding this feature..
but can i set deactivate autoplay video after i click the image?

@Catarina6
Copy link

Catarina6 commented Mar 3, 2021

Can someone help me?

I tried lightbox code but it does not pop up the youtube video. Instead it opens the youtube website.

<a href="LINK YOUTUBE VIDEO" class="image-1"><div class="thumb"> <div class="hover-effect"> <div class="hover-content"> <h1>NAME <em>NAME</em></h1> <p>SUBTITLE</p> </div> </div> <div class="image"> <img src="img/portfolio_item_4.png"> </div> </div></a></a> </div>

@peppertom
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants