Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline annotation does not work if t function contains a newline #132

Closed
JorundMartinsen opened this issue Dec 5, 2019 · 1 comment · Fixed by #826
Closed

Inline annotation does not work if t function contains a newline #132

JorundMartinsen opened this issue Dec 5, 2019 · 1 comment · Fixed by #826
Labels
fixed Already fixed in the latest version

Comments

@JorundMartinsen
Copy link

Describe the bug
Inline annotation does not work if the t function contains a newline as such:

t(
    "calendars.gregorian..."
);

This is an issue as Prettier formats long keys on new lines.

Extension Version
i18n Ally (v 1.3.3)

Framework/i18n package you are using
react-i18next

To Reproduce
Assuming existing framework, create a looong key, and type the t function as above

Desktop (please complete the following information):

  • OS: Win10
  • Version 1803
@JorundMartinsen JorundMartinsen added the bug Something isn't working label Dec 5, 2019
antfu added a commit that referenced this issue Dec 5, 2019
@antfu
fix: support multilines key detection, #132
6770c13
@antfu
Copy link
Contributor

antfu commented Dec 5, 2019

Fixed in v1.3.4. Thanks for the feedback!

@antfu antfu added fixed Already fixed in the latest version and removed bug Something isn't working labels Dec 6, 2019
@ZerdoX-x ZerdoX-x mentioned this issue Oct 28, 2022
Merged
terales added a commit that referenced this issue Aug 27, 2023
@ZerdoX-x @terales
svelte: support new lines and using get() for store (#826)
5ba4582 
* fix: issue #132 for svelte

* add `get()` support

* replace .* with {key}

* add support for spaces & line breaks in get()

* Empty commit to trigger CI

---------

Co-authored-by: Alex Terehov <terales@users.noreply.github.com>
huacnlee pushed a commit to huacnlee/i18n-ally that referenced this issue Aug 28, 2023
@ZerdoX-x @terales @huacnlee
svelte: support new lines and using get() for store (lokalise#826)
40b8dde 
* fix: issue lokalise#132 for svelte

* add `get()` support

* replace .* with {key}

* add support for spaces & line breaks in get()

* Empty commit to trigger CI

---------

Co-authored-by: Alex Terehov <terales@users.noreply.github.com>
@ZerdoX-x ZerdoX-x mentioned this issue Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Already fixed in the latest version
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

svelte: Update usageMatchRegex
2 participants
@JorundMartinsen @antfu