Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

fixes #96 #100 #101

Closed
wants to merge 1 commit into from
Closed

fixes #96 #100 #101

wants to merge 1 commit into from

Conversation

ncdm-stldr
Copy link

No description provided.

@ncdm-stldr ncdm-stldr mentioned this pull request Feb 1, 2022
Open
@ncdm-stldr
Copy link
Author

Explanation:

  • the renderer.close() sometimes creates an exception is useless because the close is already preformed by the try-catch.
  • A else block has been added because it was missing (e.g. result should not been used twice).

@publiux
Copy link

publiux commented Feb 5, 2022

This should be merged as soon as possible as this is a showstopper bug for the current flutter version.

@publiux
Copy link

publiux commented Feb 6, 2022

Pinging @lohanidamodar

@ncdm-stldr ncdm-stldr changed the base branch from master to develop February 9, 2022 15:38
@ncdm-stldr ncdm-stldr changed the base branch from develop to master February 9, 2022 15:38
@ncdm-stldr
Copy link
Author

Maybe I should ask to merge into develop instead : #102

@ncdm-stldr ncdm-stldr closed this Feb 9, 2022
@choowx2002 choowx2002 mentioned this pull request Aug 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdm-stldr @publiux @NST-NK