-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add saml app sessions table #6881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
December 13, 2024 03:47
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/saml-applications/queries/sessions.ts | 📈 +2.29 KB |
packages/core/src/tenants/Queries.ts | 📈 +174 Bytes |
packages/schemas/alterations/next-1735012422-add-saml-application-sessions-table.ts | 📈 +1.27 KB |
packages/schemas/src/foundations/jsonb-types/index.ts | 📈 +48 Bytes |
packages/schemas/src/foundations/jsonb-types/saml-application-sessions.ts | 📈 +527 Bytes |
packages/schemas/tables/saml_application_sessions.sql | 📈 +965 Bytes |
darcyYe
force-pushed
the
yemq-add-saml-app-session-table
branch
from
December 13, 2024 11:12
f06a607
to
ebeca16
Compare
4 tasks
simeng-li
reviewed
Dec 23, 2024
darcyYe
force-pushed
the
yemq-add-saml-app-session-table
branch
from
December 24, 2024 04:37
ebeca16
to
9feaea5
Compare
darcyYe
force-pushed
the
yemq-add-saml-app-session-table
branch
from
December 24, 2024 06:45
9feaea5
to
e7ca100
Compare
simeng-li
reviewed
Dec 26, 2024
simeng-li
reviewed
Dec 26, 2024
simeng-li
reviewed
Dec 26, 2024
darcyYe
force-pushed
the
yemq-add-saml-app-session-table
branch
2 times, most recently
from
December 26, 2024 04:56
43a34a7
to
965f6a2
Compare
simeng-li
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
darcyYe
force-pushed
the
yemq-add-saml-app-session-table
branch
from
December 27, 2024 04:46
965f6a2
to
fd2ea4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
saml_application_sessions
table to help improve the security of OIDC and SAML proxy. (resolves LOG-10581)applicationId
, andsamlRequestId
) in this tableoidcState
samlRequestId
and sent SAML response to the ACS URL in record and hence marked thesamlRequestId
as parsedTesting
N/A
Checklist
.changeset