feat(core): add account center api #6772
Open
+239
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/queries/account-center.ts | 📈 +1.81 KB |
| packages/core/src/routes/account-center/index.openapi.json | 📈 +1.2 KB |
| packages/core/src/routes/account-center/index.ts | 📈 +1.28 KB |
| packages/core/src/routes/init.ts | 📈 +162 Bytes |
| packages/core/src/routes/swagger/utils/documents.ts | 📈 +76 Bytes |
| packages/core/src/tenants/Queries.ts | 📈 +125 Bytes |
| packages/integration-tests/src/api/account-center.ts | 📈 +487 Bytes |
| packages/integration-tests/src/tests/api/account-center.test.ts | 📈 +776 Bytes |
| packages/schemas/src/foundations/jsonb-types/account-center.ts | 📈 +969 Bytes |
wangsijie
force-pushed
the
wangsijie-log-9896-database-table-for-profile-api-control
branch
from
4cd7e01
to
007de0a
Compare
Base automatically changed from
wangsijie-log-9896-database-table-for-profile-api-control
to
master
November 6, 2024 03:37
wangsijie
force-pushed
the
wangsijie-log-9897-api-control-for-global-and-specific-fields
branch
from
864ffa8
to
cf5f426
Compare
wangsijie
force-pushed
the
wangsijie-log-9897-api-control-for-global-and-specific-fields
branch
from
cf5f426
to
d8457c8
Compare
wangsijie
force-pushed
the
wangsijie-log-9897-api-control-for-global-and-specific-fields
branch
from
d8457c8
to
daa82e0
Compare
simeng-li
reviewed
Nov 8, 2024
Comment on lines
+19
to
+25
| public readonly insert = buildInsertIntoWithPool(this.pool)(AccountCenters, { | ||
| returning: true, | ||
| }); | ||
|
|
||
| public readonly update = buildUpdateWhereWithPool(this.pool)(AccountCenters, true); | ||
|
|
||
| public readonly find = buildFindEntityByIdWithPool(this.pool)(AccountCenters); |
There was a problem hiding this comment.
How about extending the SchemaQueries class? No need to redefine these standard query methods.
Comment on lines
+12
to
+16
| const defaultAccountCenter: Omit<AccountCenter, 'tenantId'> = { | ||
| id: 'default', | ||
| enabled: false, | ||
| fields: {}, | ||
| }; |
There was a problem hiding this comment.
Should we put this default value definition under @logto/schemas?
Actually should we seed the default value in DB with a DB alteration?
| return accountCenter; | ||
| } | ||
|
|
||
| await this.insert(defaultAccountCenter); |
There was a problem hiding this comment.
return await this.insert(defaultAccountCenter) will return the inserted value?
There was a problem hiding this comment.
As commented above, can we follow the default SIE pattern, seed the default values in DB directly? Looks to me this fallback logic is for one-time use only, should not be placed in this query method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add GET/PATCH api of account center, this settings will be used the control the global access of Profile API.
Testing
Integration tests.
Checklist
.changeset