Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console,core,connector): fix display issues and POST /connectors API code guard #6481

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Aug 20, 2024

Summary

Fix following issues:

  1. wecom connector should have platform to be universal (null platform is only for passwordless connectors, thanks to @xiaoyijun for reporting this issue)
  2. should show quota guard footer on connector creation modal for standard connectors, although we removed quota guard for standard connectors, but they will still be guarded by socailConnectorsLimit
  3. add 403 response code for POST /connectors API since 403 could be reported by backend API level quota guard

Testing

Tested locally.
image
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Aug 20, 2024

COMPARE TO master

Total Size Diff 📉 -101 Bytes

Diff by File
Name Diff
.changeset/hip-cats-destroy.md 📉 -111 Bytes
packages/connectors/connector-wecom/src/constant.ts 📉 -42 Bytes
packages/console/src/components/CreateConnectorForm/Footer/index.tsx 📉 -316 Bytes
packages/console/src/components/CreateConnectorForm/index.tsx 📉 -51 Bytes
packages/console/src/pages/TenantSettings/Subscription/PlanComparisonTable/index.tsx 📉 -10 Bytes
packages/core/src/routes/connector/index.openapi.json 📉 -118 Bytes
packages/core/src/routes/connector/index.ts 📉 -5 Bytes

@darcyYe darcyYe enabled auto-merge (squash) August 21, 2024 03:09
@darcyYe darcyYe merged commit 763dd60 into master Aug 21, 2024
34 checks passed
@darcyYe darcyYe deleted the yemq-add-footer-quota-guard-for-standard-connectors branch August 21, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants