Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): revert the custom jwt forms overflow hidden #5573

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix(console): revert the custom jwt forms overflow hidden #5573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/console/src/pages/JwtClaims/SettingsSection/TestTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,7 @@ function TestTab({ isActive }: Props) {

return (
<div className={classNames(styles.tabContent, isActive && styles.active)}>
<Card
className={classNames(styles.card, styles.flexGrow, styles.flexColumn, styles.fixHeight)}
>
<Card className={classNames(styles.card, styles.flexGrow, styles.flexColumn)}>
<div className={styles.headerRow}>
<div className={styles.cardHeader}>
<div className={styles.cardTitle}>{t('tester.title')}</div>
Expand Down
10 changes: 0 additions & 10 deletions packages/console/src/pages/JwtClaims/SettingsSection/index.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

.tabContent {
display: none;
// restrict the height of the tab content to the height of the container
overflow: hidden;

&.active {
flex: 1;
Expand Down Expand Up @@ -87,14 +85,6 @@
}
}

&.fixHeight {
overflow: hidden;

.cardContent {
overflow: hidden;
}
}

.expandButton {
width: 24px;
height: 24px;
Expand Down
5 changes: 0 additions & 5 deletions packages/console/src/pages/JwtClaims/index.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,11 @@
display: flex;
flex-direction: row;
flex-grow: 1;
// restrict the height of the tab content to the height of the container
overflow: hidden;

> * {
flex: 1;
margin-bottom: _.unit(6);

// restrict the height of the tab content to the height of the container
overflow: hidden;

&:first-child {
margin-right: _.unit(3);
}
Expand Down
Loading