Ensuring that an entire message has been sent by calling SSLSocket/TCPSocket.syswrite in loop #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
…PSocket.syswrite in loop. Fixes logstash-plugins#30 logstash-plugins#33 where messages longer than jruby-openssl OpenSSL::Buffering::BLOCK_SIZE were truncated.
raphaelsolarski
force-pushed
the
ssl-syswrite-fixup
branch
from
7b681fc to
9eadbe4
Compare
|
Hi, what does the "needs-triage" status mean? Can I help in some way? 😃 |
|
Hi, any updates? |
|
@jsvd? Sorry for pinging, but commit history indicates that you may be the appropriate person to look at this, and this PR been left without any response for over a year... I believe this may be important, considering that security is enabled by default in ES 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30 #33 where messages longer than jruby-openssl OpenSSL::Buffering::BLOCK_SIZE were truncated.