Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small cleanup turned into a sizeable one... #26

Closed
wants to merge 6 commits into from
Closed

A small cleanup turned into a sizeable one... #26

wants to merge 6 commits into from

Conversation

webmat
Copy link
Contributor

@webmat webmat commented May 9, 2018 •
edited
Loading

  • Update comment on how to get the proper key to send logs. It's the "Customer Token", not
    API Keys (which seem to fail silently).
  • Specify Content-Type.
  • Remove code comment that accidentally got into the very top of the plugin description
  • Tone down the log noise: move a few to debug, replace putses with the logger
  • Fix a typo in a log message
  • Whitespace cleanup

Closes #15, #17 and #23

@webmat
Copy link
Contributor Author

webmat commented May 9, 2018 •
edited
Loading

I will release #24 and this at the same time.

@elasticsearch-bot elasticsearch-bot self-assigned this May 9, 2018
jsvd
jsvd approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for taking the extra time for a facelift <3

@elasticsearch-bot
Copy link

Mathieu Martin merged this into the following branches!

Branch Commits
master c74ed38, eb4fa93, d7f693d, 0500802, c441650, ad51bad

elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Remove code comment that accidentally got into the public docs.
eb4fa93 
Fixes #26
elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Fix typo in 'Event sent to Loggly'
d7f693d 
Fixes #26
elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Don't puts on every successful event sent to Loggly
0500802 
Fixes #26
elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Log a warning instead of puts, when retrying
c441650 
Fixes #26
elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Replace outdated instructions wrt to finding the proper token.
ad51bad 
Fixes #26
@webmat webmat deleted the minor-cleanup branch May 9, 2018 13:51
webmat pushed a commit to webmat/logstash-output-loggly that referenced this pull request May 9, 2018
Version bump for logstash-plugins#24 and logstash-plugins#26
870e0a9
@webmat webmat mentioned this pull request May 9, 2018
Closed
webmat pushed a commit to webmat/logstash-output-loggly that referenced this pull request May 9, 2018
Version bump for logstash-plugins#24 and logstash-plugins#26
7961f3e
webmat pushed a commit to webmat/logstash-output-loggly that referenced this pull request May 9, 2018
Version bump for logstash-plugins#24 and logstash-plugins#26
10d59e6 
Squashed away a messy history...
elasticsearch-bot pushed a commit that referenced this pull request May 9, 2018
Version bump for #24 and #26
26d21cd 
Squashed away a messy history...

Fixes #27
This was referenced May 9, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees
No one assigned
Labels
docs internal-cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmat @elasticsearch-bot @jsvd