Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark_read option and fix #45 #46

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pemontto
Copy link
Contributor

@pemontto pemontto commented Sep 24, 2019

This PR adds an option mark_read set by default to true to maintain backwards compatibility. It truly allows users or other services to use the mailbox simultaneously with the IMAP input plugin.

Changes:

  • Add mark_read option
  • Grab all messages if uid_tracking is true and uid_last_value is nil
  • Add more debug messages for troubleshooting
  • Add some more detail to the docs

Fixes #45

@pemontto
Copy link
Contributor Author

Fixed merge conflict

@maxhodak
Copy link

Is there a reason this hasn't been landed? It seems like it would be very useful.

@pemontto
Copy link
Contributor Author

pemontto commented Aug 3, 2021

Any chance of a review/merge @robbavey @karenzone

@AlbertasB
Copy link

Would really like to see mark_read functionality merged

@spacemoose
Copy link

I would also like to see this merged.

@pemontto
Copy link
Contributor Author

Maybe @mashhurs can take a look?

@jsvd
Copy link
Member

jsvd commented Jun 25, 2024

@logstashmachine bump minor

@jsvd
Copy link
Member

jsvd commented Jun 25, 2024

I don't have a good way to test this right now, @spacemoose and @pemontto can you confirm this works as expected?

docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs changes. I left some suggestions for your consideration.

pemontto and others added 2 commits June 26, 2024 13:06
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with uid_tracking marking emails as read
7 participants