-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mark_read option and fix #45 #46
base: main
Are you sure you want to change the base?
Conversation
Fixed merge conflict |
Is there a reason this hasn't been landed? It seems like it would be very useful. |
Any chance of a review/merge @robbavey @karenzone |
Would really like to see |
I would also like to see this merged. |
Maybe @mashhurs can take a look? |
@logstashmachine bump minor |
I don't have a good way to test this right now, @spacemoose and @pemontto can you confirm this works as expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs changes. I left some suggestions for your consideration.
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
This PR adds an option
mark_read
set by default totrue
to maintain backwards compatibility. It truly allows users or other services to use the mailbox simultaneously with the IMAP input plugin.Changes:
true
anduid_last_value
is nilFixes #45