Use IMAP uid to retrieve new mails instead of "NOT SEEN" flag #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bdadb46)
This commit introduces new configuration options:
* `uid_tracking` - set to `true` to use IMAP uid instead of "NOT SEEN" flag
* `sincedb_path` - path to file with last processed IMAP uid. Defaults to
`#{path.data}/plugins/input/imap/.sincedb_#{Digest::MD5.hexdigest("#{@user}_#{@host}_#{@PORT}_#{@folder}")}`
IMAP uid is always stored in the file `sincedb_path` regardles of the
`uid_tracking` setting, so we can switch between "NOT SEEN" and "UID"
tracking. In transition from the previous plugin version, we first need
to process at least one mail with `uid_tracking` set to `false` to save
the last processed IMAP uid and then switch `uid_tracking` to `true`.
robbavey
reviewed
Mar 20, 2019
robbavey
reviewed
Mar 21, 2019
robbavey
approved these changes
Mar 22, 2019
|
Wait a minute please, a little improvement is on the way. |
|
Hi @robbavey, I'm done. Could you please review the changes? |
robbavey
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Code looks good - @karenzone would you mind giving the docs a quick review?
|
@prehor Let me know if you are good with these changes being merged, and I will go ahead and merge and publish the gem. Thanks again for the contribution! |
|
I think that it is finished. Today I downloaded approximately 10.000 emails from Gmail and plugin was working well. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
This commit introduces new configuration options:
* `uid_tracking` - set to `true` to use IMAP uid instead of "NOT SEEN" flag
* `sincedb_path` - path to file with last processed IMAP uid. Defaults to
`#{path.data}/plugins/input/imap/.sincedb_#{Digest::MD5.hexdigest("#{@user}_#{@host}_#{@PORT}_#{@folder}")}`
IMAP uid is always stored in the file `sincedb_path` regardles of the
`uid_tracking` setting, so we can switch between "NOT SEEN" and "UID"
tracking. In transition from the previous plugin version, we first need
to process at least one mail with `uid_tracking` set to `false` to save
the last processed IMAP uid and then switch `uid_tracking` to `true`.
Fixes #36
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
|
@prehor Thanks for the pointer - I've just assigned it to myself to review and will take a look at it shortly. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following configuration options:
uid_tracking- set totrueto use IMAP uid instead of "NOT SEEN" flag. defaults tofalsesincedb_path- path to file with last processed IMAP uid. Defaults to<path.data>/plugins/inputs/imapIMAP uid is always stored in the file
sincedb_pathregardles of theuid_trackingsetting, so you can switch between "NOT SEEN" and "UID" tracking. In transition from the previous plugin version, first process at least one mail withuid_trackingset tofalseto save the last processed IMAP uid and then switchuid_trackingtotrue.Fixies #31