Fix: behavior incompatiblity between (standalone) LS and LS in Docker #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem including expected versus actual behavior (from #29):
PENDING suggestion from #28 (comment) :
when command fails
on a platform where IO.popen raises ENOENT
it does not enqueue an event
on a platform where IO.popen does not raise ENOENT (Docker)
it enqueues an event tagged with the error code
Ideally we would rather want the same behavior in Docker vs non-Docker LS ...
By switching to
Open3
'spopen
the behavior is now consistent between LS in Docker and standalone LS.Previously, when a user would run Docker-ized LS using the exec input and points to a wrong/missing executable to run, the plugin would generates (error) events with a non-zero exit status (
127
), in standalone mode no events would have been generated.