Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECS field region_iso_code #205

Closed

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Jan 13, 2022

This commit changes the ECS field from geo.region_code to geo.region_iso_code

Before this change, 52.168.174.229 gives region_code: VA

The source of region_code is Maxmind iso_code. region_code is not a ECS field but region_iso_code is.
In ECS example the value ofregion_iso_code is CA-QC, which seems to be a combination of country iso code and region iso code. So, the current region_code is not the same as ECS schema region_iso_code.

Questions:

  1. Can we change geo.region_code to geo.region_iso_code or keep it as is?

Fixed: #195

@kaisecheng
Copy link
Contributor Author

need to combine country iso code and region iso code instead of renaming the field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing ECS fields
2 participants