Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the ECS field from
geo.region_code
togeo.region_iso_code
Before this change,
52.168.174.229
givesregion_code
:VA
The source of
region_code
is Maxmindiso_code
.region_code
is not a ECS field butregion_iso_code
is.In ECS example the value of
region_iso_code
isCA-QC
, which seems to be a combination of country iso code and region iso code. So, the currentregion_code
is not the same as ECS schemaregion_iso_code
.Questions:
geo.region_code
togeo.region_iso_code
or keep it as is?Fixed: #195