Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure resulting class files can be run on Java 8 #197

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Ensure resulting class files can be run on Java 8 #197

merged 2 commits into from
Dec 13, 2021

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Dec 13, 2021

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

yaauie
yaauie commented Dec 13, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
robbavey
robbavey approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaauie
Copy link
Contributor Author

yaauie commented Dec 13, 2021

Build failure caused by logstash-plugins/.ci#31 and unrelated to these changes.

@yaauie yaauie merged commit 479934b into logstash-plugins:main Dec 13, 2021
@yaauie yaauie deleted the java-8-support branch December 13, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaauie @robbavey