Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strategy to understand if user customised decode_size_limit_bytes #47

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Update strategy to understand if user customised decode_size_limit_bytes #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f06af8
Use original_params to understand if user has customized the setting …
andsel Sep 6, 2024
d1df694
Bumped new version
andsel Sep 6, 2024
622decb
Minor, fixed typo
andsel Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 3.2.2
- Fix: updated the way to check if the `decode_size_limit_bytes` has been explicitly customised. [#47](https://github.com/logstash-plugins/logstash-codec-json_lines/pull/47)

## 3.2.1
- Raise the default value of `decode_size_limit_bytes` up to 512 MB. [#46](https://github.com/logstash-plugins/logstash-codec-json_lines/pull/46)

Expand Down
2 changes: 1 addition & 1 deletion lib/logstash/codecs/json_lines.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class LogStash::Codecs::JSONLines < LogStash::Codecs::Base
public

def register
if decode_size_limit_bytes == DEFAULT_DECODE_SIZE_LIMIT_BYTES
if original_params['decode_size_limit_bytes'].nil?
deprecation_logger.deprecated "The default value for `decode_size_limit_bytes`, currently at 512Mb, will be lowered in a future version to prevent Out of Memory errors from abnormally large messages or missing delimiters. Please set a value that reflects the largest expected message size (e.g. 20971520 for 20Mb)"
end
@buffer = FileWatch::BufferedTokenizer.new(@delimiter, @decode_size_limit_bytes)
Expand Down
2 changes: 1 addition & 1 deletion logstash-codec-json_lines.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Gem::Specification.new do |s|

s.name = 'logstash-codec-json_lines'
s.version = '3.2.1'
s.version = '3.2.2'
s.licenses = ['Apache License (2.0)']
s.summary = "Reads and writes newline-delimited JSON"
s.description = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
Expand Down