add flush support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could this be considered a breaking change? are there other places where we've done this already? |
|
@jsvd this is exactly the same idea as with the line codec, any/all delimited content codec should support the flush method for situation such as logstash-plugins/logstash-input-http#81 or logstash-plugins/logstash-input-udp@ecf93e1#diff-f55c7d32f8cd66e4be73265d1b1d2342R122 In essence, this is not a breaking change but a fix to a potential data loss or corruption problem with inputs such as udp or http. |
|
Thanks @jsvd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20 and it also fixes the issue with inputs like http where each received payload will always yield one or many json lines but may not contain a delimiter on the last one. These inputs need to call flush after each request to make sure any buffers are emptied.
This codec will now be consistent with the line codec which also support the flush method in the same way.
Also, for reference, this flush "semantic" was discussed in elastic/logstash#8830