Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directly use buftok to avoid indirection through the line codec #18

Merged
merged 3 commits into from
Feb 5, 2016
Merged

directly use buftok to avoid indirection through the line codec #18

merged 3 commits into from
Feb 5, 2016

Conversation

colinsurprenant
Copy link
Contributor

as discussed in #17

this does not solve the flushing issue raised. we can either create a new PR for it or include that fix here.

@guyboertje
Copy link
Contributor

Suggest: get this merged and then deal with flush

@guyboertje
Copy link
Contributor

LGTM
(did not test locally - I trust Jenkins for this small change)

@colinsurprenant
Copy link
Contributor Author

For the sake of completeness I quickly measured the performance impact using logstash-performance-testing and the "json codec in/out" test and a few runs is showing an approximately 10% increase in TPS. The impact is not massive but it is not negligible either.

@colinsurprenant
Copy link
Contributor Author

merging and pushing

@colinsurprenant colinsurprenant merged commit 257cbd7 into logstash-plugins:master Feb 5, 2016
@colinsurprenant
Copy link
Contributor Author

published 2.0.5

@suyograo suyograo mentioned this pull request Feb 5, 2016
Closed
@colinsurprenant colinsurprenant mentioned this pull request Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinsurprenant @guyboertje