Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added target configuration + event-factory support #31

Merged
merged 11 commits into from
Aug 4, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Jul 26, 2021

This PR starts leveraging event_factory support in the codec plugin.
Also added an optional config :target.

Additionally we reduced the number of "global" constants this plugin introduces + added at least debug logging on errors.

@kares kares marked this pull request as ready for review July 27, 2021 05:12
@kares kares changed the title Feat: setup event-factory support Feat: added target configuration + event-factory support Jul 28, 2021
@kaisecheng kaisecheng self-requested a review July 28, 2021 09:57
Copy link

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the changelog, otherwise, LGTM 🧙

Copy link

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM! 🚀

@kares kares merged commit 5ce9c34 into logstash-plugins:master Aug 4, 2021
@andsel andsel self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants