Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing issues #25

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Addressing issues #25

merged 2 commits into from
Dec 1, 2023

Conversation

eatpk
Copy link
Collaborator

@eatpk eatpk commented Nov 25, 2023 •
edited
Loading

Addressed #24

Tested with mnist examples + compute_influence and compute_influence_pca.

@eatpk eatpk merged commit 6130ab5 into main Dec 1, 2023
2 checks passed
@sangkeun00
Copy link
Collaborator

@eatpk can this change potentially affect the performance of data io?

@eatpk
Copy link
Collaborator Author

eatpk commented Dec 1, 2023 •
edited
Loading

Not in theory, let me know if you see degradation of performance. @sangkeun00
This can only impact if we reread the freed binary file, which I don't think is the case since we do a sequential read

@eatpk eatpk deleted the fix-2 branch December 9, 2023 14:05
@sangkeun00 sangkeun00 mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangkeun00 sangkeun00 Awaiting requested review from sangkeun00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatpk @sangkeun00