Unittest PR for workflow update #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. You can merge the request after fixing the black-formatting issue. |
eatpk
force-pushed
the
unit-test-compute
branch
8 times, most recently
from
827110e
to
9866c7f
Compare
eatpk
force-pushed
the
unit-test-compute
branch
from
6b32cc6
to
1e439b0
Compare
eatpk
force-pushed
the
unit-test-compute
branch
from
76b208e
to
e4344cb
Compare
eatpk
force-pushed
the
unit-test-compute
branch
from
26795eb
to
d55deaf
Compare
eatpk
commented
Nov 20, 2023
Comment on lines
+11
to
+19
| def construct_mlp(num_inputs=784, num_classes=10): | ||
| return torch.nn.Sequential( | ||
| nn.Flatten(), | ||
| nn.Linear(num_inputs, 4, bias=False), | ||
| nn.ReLU(), | ||
| nn.Linear(4, 2, bias=False), | ||
| nn.ReLU(), | ||
| nn.Linear(2, num_classes, bias=False), | ||
| ) |
There was a problem hiding this comment.
I tried to make to smaller version of the model.
eatpk
commented
Nov 20, 2023
Comment on lines
+1
to
+8
| import unittest | ||
| import torch | ||
| import torchvision | ||
| import torch.nn as nn | ||
| import numpy as np | ||
| import os | ||
|
|
||
| DEVICE = torch.device("cpu") |
There was a problem hiding this comment.
Only testing the compute_influence as I think the train.py does not include anything from analog lib.
I strongly think that this test may have to be removed before the public release from the /tests/ as this is not pertaining to the actual module we are building. However, I am leaving it here as per the internal contributors may overlook the test run of their work in local with the mnist data.
Caveat, this may not well represent the overall behavior of the module as the sheer size of the model architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.