Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow for PRs #13

Merged
merged 11 commits into from
Nov 19, 2023
Merged

Github workflow for PRs #13

merged 11 commits into from
Nov 19, 2023

Conversation

eatpk
Copy link
Collaborator

@eatpk eatpk commented Nov 19, 2023

  1. Auto re-format when opening a PR.
  2. Unit test.(Test everything ending with _test.py)

Comment on lines +26 to +28
pip install --upgrade pip
pip install msgpack # TODO: Update this as we update requirements.txt
python setup.py install
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason, if I leave pip install msgpack out, it fails:
https://github.com/sangkeun00/analog/actions/runs/6919422313/job/18822772616
hence, I am installing this separately. When we give versioning to the requirements.txt we would have to change it here to. I am leaving TODO.

@sangkeun00
Copy link
Collaborator

LGTM

@eatpk eatpk merged commit b54b3a1 into main Nov 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants