-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github workflow for PRs #13
Conversation
pip install --upgrade pip | ||
pip install msgpack # TODO: Update this as we update requirements.txt | ||
python setup.py install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason, if I leave pip install msgpack out, it fails:
https://github.com/sangkeun00/analog/actions/runs/6919422313/job/18822772616
hence, I am installing this separately. When we give versioning to the requirements.txt we would have to change it here to. I am leaving TODO.
LGTM |
_test.py
)