Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeORM config #10

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix TypeORM config #10

merged 1 commit into from
Jun 8, 2023
+88 −13

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Jun 8, 2023

  • When read from environment, synchronize and logging are strings and interpreted as true if not falsy.
  • This fix ensures that the variable has value "true" (the string) to be considered as true (the boolean).
  • Without this, TypeORM was syncing the schema, even if the variable was equal to "false" (the string).
  • Tests were added to prevent any regression on this.

@gdethier gdethier requested a review from benoitdevos June 8, 2023 11:58
@gdethier gdethier changed the title Fix typeorm config Fix TypeORM config Jun 8, 2023
benoitdevos
benoitdevos approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch !

@gdethier gdethier merged commit 98429e2 into main Jun 8, 2023
@gdethier gdethier deleted the feature/fix-typeorm-config branch June 8, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos