Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare migration #7

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Prepare migration #7

merged 11 commits into from
Apr 4, 2024

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Apr 3, 2024 •
edited
Loading

Prepare migration

  • Configure Logion pallets in runtime (Re-use weights calculated for solo).
  • Adapt genesis config.
  • Remove useless migration.

logion-network/logion-internal#1199

gdethier
gdethier requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I have a few comments that IMHO must be handled before the branch can be merged.

runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
gdethier
gdethier approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoitdevos benoitdevos merged commit 96d738a into main Apr 4, 2024
1 check passed
@benoitdevos benoitdevos deleted the feature/prepare-migration branch April 4, 2024 07:07
@benoitdevos benoitdevos mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdethier gdethier gdethier approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitdevos @gdethier