Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store public item/record data #259

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Store public item/record data #259

merged 1 commit into from
Jul 14, 2023

Conversation

gdethier
Copy link
Contributor

  • Story https://github.com/logion-network/logion-internal/issues/948 requires that all public data related to items and records are submitted to the backend, otherwise hashing them on-chain would lead to a data loss
  • Public data are submitted to backend before extrinsic submission in order to prevent concurrent updates (sync and client) and the potential data loss this represents (sync does not have the public data anymore, while client does).
  • If extrinsic submission fails, submitted public data must be discarded.
  • As a result, file upload is simplified: the collection items and tokens records always exist in the DB on upload (but have no CID as long as the file has not been uploaded).
  • The mechanism has been implemented for collection items and tokens records.

logion-network/logion-internal#952

@gdethier gdethier merged commit e9f0e21 into main Jul 14, 2023
2 checks passed
@gdethier gdethier deleted the feature/copy-chain-data branch July 14, 2023 09:14
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants