Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all transaction statuses #273

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Handle all transaction statuses #273

merged 1 commit into from
Jun 28, 2024

Conversation

gdethier
Copy link
Contributor

  • Be robust to signer callback failures (i.e. thrown errors)
  • Explicitly handle "final" transaction statuses (even if canUnsub does not)
  • Reject signAndSend promise for all erroneous statuses

logion-network/logion-internal#1311

benoitdevos
benoitdevos approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier merged commit 4642b96 into main Jun 28, 2024
2 checks passed
@gdethier gdethier deleted the feature/handle-all-transaction-statuses branch June 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos