Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only on-chain collection items #254

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Show only on-chain collection items #254

merged 2 commits into from
Apr 23, 2024

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Apr 23, 2024

  • getCollectionItems() return only items present on-chain.

This fixes the problem logion-network/logion-internal#1225 where all items are hidden when some item is not written on-chain(typically lack of funds or signature cancelled), and for some reason (typically browser refresh or close) the cancel to backend is not performed.

Also fixed minor glitch in TS-doc.

Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoitdevos benoitdevos merged commit 562c387 into main Apr 23, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/merge-items branch April 23, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants