Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other account types. #252

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

benoitdevos
Copy link
Contributor

@benoitdevos benoitdevos commented Apr 17, 2024

  • Add support for other account types
  • Add method fromUnknown() - aiming at detecting account type from address.
  • Provide strong validation of Bech32 addresses - otherwise almost any dummy addresses were accepted as valid Bech32 addresses. (using bitcoinjs/bech32)
  • Provide a stronger validation for Polkadot addresses - for some reasons the previous implementation using validateAddress() used to validate addresses that were later on unable to decode. The new implementation is strongly inspired from checkAddress()

logion-network/logion-internal#1216

@benoitdevos benoitdevos changed the title Add support for other account types; validate Bech32 addresses. Add support for other account types. Apr 17, 2024
Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@benoitdevos benoitdevos merged commit 60e93bd into main Apr 17, 2024
2 checks passed
@benoitdevos benoitdevos deleted the feature/manage-other-accounts branch April 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants