fix(unhandledPromise): error.message is overwritten
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix bug where unhandledPromiseRejection handler was overwritting the `error.message` with <unknown> Fix #38 Semver: patch
joemaddalone
approved these changes
May 2, 2022
|
🎉 This PR is included in version 2.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lmcarreiro
reviewed
May 2, 2022
| @@ -25,7 +25,7 @@ const addUnhandledrejection = () => { | |||
|
|
|||
| /* istanbul ignore next */ | |||
| const onUnhandledRejection = (e: any) => { | |||
| let error = e; | |||
| let error: any = {}; | |||
There was a problem hiding this comment.
Now sure, but now if one of e.reason or e.detail.reason is a string, even if e instanceof Error, it will lose the stack trace info, because else if (typeof reason === 'string') comes before else if (e instanceof Error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix bug where unhandledPromiseRejection handler was overwritting
the
error.messagewithFix #38
Semver: patch