fix: make sure process.getuid doesn't get called on Windows
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smusali
force-pushed
the
smusali/LOG-6981
branch
from
348203a to
584b179
Compare
mdeltito
requested changes
Aug 21, 2020
smusali
force-pushed
the
smusali/LOG-6981
branch
3 times, most recently
from
44fc8b7 to
ca5f67d
Compare
smusali
force-pushed
the
smusali/LOG-6981
branch
from
ca5f67d to
594133f
Compare
mdeltito
reviewed
Aug 21, 2020
smusali
force-pushed
the
smusali/LOG-6981
branch
from
594133f to
cc81479
Compare
mdeltito
previously approved these changes
Aug 21, 2020
matt-march
reviewed
Aug 21, 2020
matt-march
reviewed
Aug 21, 2020
`process.getuid` method isn't supported on `Windows` as explained [here](https://nodejs.org/api/process.html#process_process_getuid); so, this commit is for fixing that bug. Ref: LOG-6981 Semver: patch
smusali
force-pushed
the
smusali/LOG-6981
branch
from
cc81479 to
da6f4d6
Compare
mdeltito
approved these changes
Aug 21, 2020
matt-march
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.getuidmethod isn't supported onWindowsas explained here; so, this commit is for fixing that bug.Ref: LOG-6981
Semver: patch