fix: Added custom resources to host to pro check #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
hidalgopl
requested changes
Oct 15, 2024
There was a problem hiding this comment.
could you add a test case to https://github.com/loft-sh/vcluster/blob/main/config/config_test.go#L144 as well? Thanks!
ThomasK33
force-pushed
the
thomaskosiewski/add-custom-resources-to-pro-check
branch
from
b6657f2
to
3057412
Compare
johannesfrey
approved these changes
Oct 15, 2024
hidalgopl
approved these changes
Oct 15, 2024
ThomasK33
deleted the
thomaskosiewski/add-custom-resources-to-pro-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
Please provide a short message that should be published in the vcluster release notes
Add custom resources to host syncing to pro check
What else do we need to know?