Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): support react native 0.77 #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

believer
Copy link

@believer believer commented Jan 22, 2025

Thanks for this great library!

Due to this change in React Native core getString now returns String?. Since the when condition checks that the current value is a string, I think it's fine to type cast the result as a String. I tested it locally and it resolves the error.

Alternatively, we could go the route of only adding the value if it exists using:

	ReadableType.String -> sizes.getString(i)?.let { result.add(it) }

Copy link

vercel bot commented Jan 22, 2025

@believer is attempting to deploy a commit to the Jovanni's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 5912299 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant