Add python3 support #328
Add python3 support #328
Conversation
|
Looks like there are a lot of whitespace changes. You should probably move those into a separate PR, it makes it really hard to review. |
| @@ -47,7 +47,7 @@ def run(self): | |||
| packages=find_packages(exclude=['ez_setup', 'examples', 'tests']), | |||
| include_package_data=True, | |||
| zip_safe=False, | |||
| install_requires=["gevent>=1.0.1", "flask>=0.10.1", "requests>=2.4.1", "msgpack-python>=0.4.2"], | |||
| install_requires=["gevent>=1.0.1", "flask>=0.10.1", "requests>=2.4.1", "msgpack-python>=0.4.2", "future>=0.15.0", "six>=1.9.0"], | |||
There was a problem hiding this comment.
I don't think gevent 1.0.1 is compatible with Python 3. You need >=1.1, see https://github.com/gevent/gevent/blob/master/changelog.rst#11a1-jun-29-2015.
|
@pmdarrow, I will try to make a commit reverting all the whitespace changes tomorrow. In the meantime, if you want, you can add ?w=1 to the end of the URL, github will show the diff with only non-whitespace changes. Thanks! |
|
Has this been merged into master yet? I have a dependency on this happening in order to use locust with Python 3. |
|
This has not been merged. Can any core maintainers comment on this? It looks like this PR has been sufficiently cleaned up. |
|
Any ETA here on when this can be merged? Dependency also here that needs 3 support if possible. |
|
It appears this project is no longer being actively maintained (see commits for 2015). We might be better served by maintaining our own Python 3 fork. |
|
@pmdarrow thanks for that. I was hoping for a last fix so I didn't have to do it myself. Might have to keep using Gatling since that's currently running already in our infrastructure. Best! |
|
Cleaned things up a little bit more in #363 and pinged the repo owners — hopefully we can get this merged! |
|
Closing this in favor of #363, which is being actively developed. |
Bunch of stuff that causes locustio to pass all tests in python2 and python3.
Let me know if you find anything that isn't working.