Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI Should use Built-In Echarts Time Axis #2847

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

andrewbaldwin44
Copy link
Collaborator

@andrewbaldwin44 andrewbaldwin44 commented Aug 13, 2024

Proposal

  • The webui currently uses the 'category' type for the charts. We should use the built-in 'time' axis type instead, which will give us better looking time intervals, rather than random splits
  • Update how chart history recorded is recorded in Locust to be formatted in the way echarts expects for time data ([time, data][] rather than data[])
  • Update tests and types

Tested

  • Ensure the mark line (between multiple test runs) continues to work as expected
  • Ensure a chart from recorded history is rendered properly
  • Ensure the HTML report is properly rendered

Screenshots

image
image
image

@cyberw
Copy link
Collaborator

cyberw commented Aug 14, 2024

Nice! Ok to merge or is there a reason it is in draft?

@andrewbaldwin44 andrewbaldwin44 marked this pull request as ready for review August 14, 2024 12:07
@cyberw cyberw merged commit 5cb7370 into locustio:master Aug 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants