Fix #1910 KeyboardInterrupt with load shapes #2375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest this is probably more of a bandaid solution, but for dealing with
KeyboardInterrupt
this is hopefully sufficient. I've added an integration test that raises aKeyboardInterrupt
. The logic being that if properly handled, the test will end properly,@events.test_stop.add_listener
will execute, and a report will be generated.