Updated request event with context and deprecate request_failure/success #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will also add kwargs handling to request events.
…led requests. The old request_success and request_failed still exists but should probably be removed at some point.
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
cyberw
reviewed
Apr 23, 2021
|
Got some errors in the build there, but other than that (and my comments) it looks good. Oh, and dont forget to update the xmlrpc example (both in examples/ and in extending-locust.rst) |
|
Oh, and write something clever in changelog.rst |
cyberw
reviewed
Apr 27, 2021
Will allow getting the calling user in the request event.
Context returned from this method is forwarded in requests performed with httpSession and fastHttpSession. Allows context to be connected to a User.
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
| @@ -322,6 +315,7 @@ def __init__(self, environment): | |||
| max_redirects=self.max_redirects, | |||
| max_retries=self.max_retries, | |||
| insecure=self.insecure, | |||
| user=self, | |||
There was a problem hiding this comment.
fudge. seems like we might as well be passing only self
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 29, 2021
cyberw
reviewed
Apr 30, 2021
docs/testing-other-systems.rst
Outdated
| @@ -32,7 +31,7 @@ using ``abstract = True`` which means that Locust will not try to create simulat | |||
|
|
|||
| The ``XmlRpcClient`` is a wrapper around the standard | |||
| library's :py:class:`xmlrpc.client.ServerProxy`. It basically just proxies the function calls, but with the | |||
| important addition of firing :py:attr:`locust.event.Events.request_success` and :py:attr:`locust.event.Events.request_failure` | |||
| important addition of firing :py:attr:`locust.event.Events.request` | |||
| events, which will record all calls in Locust's statistics. | |||
cyberw
reviewed
Apr 30, 2021
cyberw
changed the title
cyberw
added a commit
that referenced
this pull request
May 3, 2021
… little bit to the discussion in #1750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a single event thats triggered both on request succes/failure #1724
This new event can contain metadata (called context) which can be specified when performing the request.