-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add friendlier message about expected limit #1566
Conversation
Will now print something like this to standard out: ``` [2020-09-17 09:39:33,411] 7131dd94fc3b/WARNING/locust.main: System open file limit '2048' is below recommended setting '10000'. It's not high enough for load testing, and the OS didn't allow locust to increase it by itself. See https://github.com/locustio/locust/wiki/Installation#increasing-maximum-number-of-open-files-limit for more info. ``` Since the expected setting isn't documented without this message it's hard to know what the recommended value is.
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
+ Coverage 81.38% 82.07% +0.69%
==========================================
Files 28 28
Lines 2557 2572 +15
Branches 392 392
==========================================
+ Hits 2081 2111 +30
+ Misses 381 368 -13
+ Partials 95 93 -2
Continue to review full report at Codecov.
|
The recommended limit is actually "as high as possible". The reason I chose 10000 is because that is the highest we can automatically increase it to on macOS. Not sure what would be the best way to describe it... |
Overall I prefer a short log entry but maybe some more details in the wiki entry. |
@cyberw Ok, so what action should I take? I'm not against any of the suggestions, but I'm not sure what you want me to do with this PR. |
I guess if you just change the word ”recommended” to ”minimum” that is good enough for me to merge. |
Dont forget to format using Black :) (if you can configure your editor to automatically do that, then feel free to add that config to the repo, like it is for VS Code at the moment) |
@cyberw I do have black with vscode. So my changes are formatted with black. However I chose not to include the formatting changes that had nothing to do with my changes to make it clear. |
Oh you have that as a step in CI. I see. |
thanks! |
Will now print something like this to standard out:
Since the expected setting isn't documented without this message it's
hard to know what the recommended value is.