feat(ingest): Allow option to group segments with ground truth #3509
+320
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL:
Summary
Currently we only group segments heuristically but many organisms also have assembly information where we have ground truth grouping information - sadly this is not an element of the ncbi dataset that we download but it can be downloaded separately to create a source of truth JSON that can be used for grouping segments.
This is great as we cannot group segments when there is any ambiguity, and it is not uncommon for there to be metadata differences between segments within an assembly.
Screenshot
PR Checklist