fix(config): remove unused secrets.database.data.host in values.yaml
#3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yaml AFAICS, this was introduced here: e76d3eb#diff-8c45270b76bf36f08f571b509614d6672984b0604844a487a0ad3ba2ad794943R1467 But then later not used anymore: 43bdbf0#diff-2770ff9da854df0d7d21f7b41e229f84677a4b0562825d22e84ca421f8a4e3f8R66 Currently, the Loculus docs also don't mention it.
fengelniederhammer
requested review from
theosanderson,
corneliusroemer and
anna-parker
fengelniederhammer
added
preview
|
I'm not sure whether we should label this as breaking - previous config will still work as the config value will be even more unused than now. |
|
Thanks for the catch! Preview looks good! LGTM! |
anna-parker
approved these changes
Oct 24, 2024
anna-parker
changed the title
secrets.database.data.host in values.yamlsecrets.database.data.host in values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview URL: https://removeunuseddbhost.loculus.org/
Summary
AFAICS, this was introduced here:
e76d3eb#diff-8c45270b76bf36f08f571b509614d6672984b0604844a487a0ad3ba2ad794943R1467 But then later not used anymore:
43bdbf0#diff-2770ff9da854df0d7d21f7b41e229f84677a4b0562825d22e84ca421f8a4e3f8R66
Currently, the Loculus docs also don't mention it.
I did not find any usage. But it would be good to have a second pair of eyes checking.
Update: This field does not exist in ppx - so no need to config changes when rolling out to ppx.
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.