Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop animating button entrance #1066

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Stop animating button entrance #1066

merged 4 commits into from
Feb 21, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Feb 21, 2024

DaisyUI makes all buttons "pop" into view with animation. It's not good! This should prevent it.

Also we now preload the logo to try to prevent CLS there.

Preview:

https://stop-animating-buttons.loculus.org/

compare how the "Choose organism" bounces on reload at https://main.loculus.org

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Feb 21, 2024
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice looks much better!

@theosanderson theosanderson merged commit 6a58697 into main Feb 21, 2024
12 checks passed
@theosanderson theosanderson deleted the stop-animating-buttons branch February 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants