-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative silo limit #1025
Alternative silo limit #1025
Conversation
Sorry I was confused - I thought this was my PR and these were your comments and I didn't know how to do them :) |
But same for all instances IIRC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of nice ideas!
Alright, I've made it go back to the roots - but with correct syntax :D |
Changed base to main after @theosanderson's closing of #1022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Could be worth doing a bit of testing over repeated cycles, which I haven't. But code LGTM. Thanks for fixing up my syntax :)
And we can consider per-organism limits for post-MVP - it wouldn't be hard (but I also can't face doing it myself this sec :) ) |
I haven't found a way to get yaml schema to work with kubernetes, would be great help for vscode. I'll notice bugs on main - I mean things were broken for 18h and this can't be worse. |
preview URL: https://alternative-silo-limit.loculus.org
Summary
resolves #1020 (at least partially)