Skip to content

Commit

Permalink
No need to wait for particular images, kubernetes will retry pulling …
Browse files Browse the repository at this point in the history
…images and backoff if not found

Given we build many docker images, we would otherwise wait for each - not just the 2 here.

Instead, use timeout to fail if the images never make it.
  • Loading branch information
corneliusroemer committed Feb 28, 2024
1 parent d151430 commit 3be6d17
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions .github/workflows/e2e-k3d.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,13 @@ jobs:
run: cd website && npx playwright install-deps
if: steps.playwright-cache.outputs.cache-hit == 'true'

- name: Wait for Backend Docker Image
uses: lewagon/wait-on-check-action@v1.3.3
with:
ref: ${{ github.sha }}
check-name: Build Backend Docker Image
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Wait for Website Docker Image
uses: lewagon/wait-on-check-action@v1.3.3
with:
ref: ${{ github.sha }}
check-name: Build Website Docker Image
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Deploy with helm
uses: WyriHaximus/github-action-helm3@v4
with:
exec: ./deploy.py --verbose helm --branch ${{ github.ref_name }} --sha ${{ github.sha }} --dockerconfigjson ${{ secrets.GHCR_DOCKER_CONFIG }}

- name: Wait for the pods to be ready
timeout-minutes: 10
run: ./.github/scripts/wait_for_pods_to_be_ready.py
- name: Sleep for 20 secs
run: sleep 20
Expand Down

0 comments on commit 3be6d17

Please sign in to comment.