Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re rebase better attribute parser #176

Merged

Conversation

sebastienbeau
Copy link
Contributor

Rebase #170

@sebastienbeau sebastienbeau force-pushed the re-rebase-better-attribute-parser branch 2 times, most recently from 81c0bff to 859707e Compare March 22, 2020 20:57
Copy link
Member

@did did left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @sebastienbeau

lib/locomotive/steam/liquid/tags/concerns/attributes.rb Outdated Show resolved Hide resolved
lib/locomotive/steam/liquid/tags/concerns/attributes.rb Outdated Show resolved Hide resolved
lib/locomotive/steam/liquid/tags/concerns/attributes.rb Outdated Show resolved Hide resolved
lib/locomotive/steam/liquid/tags/concerns/attributes.rb Outdated Show resolved Hide resolved
lib/locomotive/steam/liquid/tags/concerns/path.rb Outdated Show resolved Hide resolved
@sebastienbeau
Copy link
Contributor Author

@did fixed

@sebastienbeau sebastienbeau force-pushed the re-rebase-better-attribute-parser branch from af8d3e3 to c3d0a2f Compare March 23, 2020 16:08
- Implement AST Parser
- improve test
@sebastienbeau sebastienbeau force-pushed the re-rebase-better-attribute-parser branch from c3d0a2f to 22606d1 Compare March 31, 2020 20:26
@did did merged commit b85211e into locomotivecms:master Sep 7, 2022
did added a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants