Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry initializer #531

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions loco-extras/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ tower = { workspace = true, optional = true }
tower-http = { workspace = true, optional = true, features = [
"normalize-path",
] }
opentelemetry = { version = "0.22" , optional = true}
opentelemetry-otlp = { version = "0.15", optional = true, features = ["grpc-tonic"] }
axum-tracing-opentelemetry = { version = "0.18", optional = true }
init-tracing-opentelemetry = { version = "0.18", optional = true , features = ["otlp", "tracing_subscriber_ext"] }
tracing-opentelemetry-instrumentation-sdk = { version = "0.18", optional = true }
tracing-subscriber = { version = "0.3.18", optional = true , features = ["env-filter", "json"] }
tracing = { version = "0.1.40", optional = true }

[dependencies.loco-rs]
path = "../"
Expand All @@ -34,9 +41,12 @@ full = [
"initializer-extra-db",
"initializer-multi-db",
"initializer-normalize-path",
"initializer-opentelemetry",
]

initializer-prometheus = ["dep:axum-prometheus"]
initializer-extra-db = []
initializer-multi-db = ["dep:serde_json"]
initializer-normalize-path = ["dep:tower", "dep:tower-http"]
initializer-opentelemetry = ["dep:opentelemetry","dep:opentelemetry-otlp","dep:axum-tracing-opentelemetry",
"dep:init-tracing-opentelemetry", "dep:tracing-opentelemetry-instrumentation-sdk","dep:tracing-subscriber","dep:tracing"]
2 changes: 2 additions & 0 deletions loco-extras/src/initializers/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,5 @@ pub mod multi_db;
pub mod normalize_path;
#[cfg(feature = "initializer-prometheus")]
pub mod prometheus;
#[cfg(feature = "initializer-opentelemetry")]
pub mod opentelemetry;
11 changes: 11 additions & 0 deletions loco-extras/src/initializers/opentelemetry/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Opentelemetry Initializer

This initializer is responsible for initializing tracing with opentelemetry and adding it as a middleware in axum.

Because opentelemetry tracing initializer is not compatible with loco's default tracing initialization we must turn off the default logging.

````
fn init_logger(_config: &config::Config, _env: &Environment) -> Result<bool> {
Ok(true)
}
````
30 changes: 30 additions & 0 deletions loco-extras/src/initializers/opentelemetry/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
use axum::{async_trait, Extension, Router as AxumRouter};
use axum_tracing_opentelemetry::middleware::{OtelAxumLayer, OtelInResponseLayer};
use loco_rs::{app::{AppContext, Initializer}, Error, Result};

pub struct OpenTelemetryInitializer;

#[async_trait]
impl Initializer for OpenTelemetryInitializer {
fn name(&self) -> String {
"opentelemetry".to_string()
}

async fn before_run(&self, _app_context: &AppContext) -> Result<()> {
match init_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers() {
Ok(_) => Ok(()),
Err(e) => {
tracing::error!("Failed to initialize opentelemetry subscriber: {:?}", e);
Err(Error::Message(e.to_string()))
}
}
}


async fn after_routes(&self, router: AxumRouter, _ctx: &AppContext) -> Result<AxumRouter> {
let router = router
.layer(OtelInResponseLayer::default())
.layer(OtelAxumLayer::default());
Ok(router)
}
}
1 change: 1 addition & 0 deletions loco-extras/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@
//! * `initializer-extra-db` Adding extra DB connection
//! * `initializer-multi-db` Adding extra DB's connection
//! * `initializer-normalize-path` Normalize the request path
//! * `initializer-opentelemetry` For adding opentelemetry tracing
pub mod initializers;