support binding and port in cli command #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondot
reviewed
Jan 28, 2024
| @@ -283,7 +294,14 @@ pub async fn main<H: Hooks, M: MigratorTrait>() -> eyre::Result<()> { | |||
| }; | |||
|
|
|||
| let boot_result = create_app::<H, M>(start_mode, &environment).await?; | |||
| start(boot_result).await?; | |||
| let serve_config = ServeConfig { | |||
| port: port.map_or(boot_result.app_context.config.server.port, |p| p), | |||
There was a problem hiding this comment.
is it just .or(...)? (since the map is identity)
jondot
reviewed
Jan 28, 2024
src/cli.rs
Outdated
| @@ -283,7 +294,14 @@ pub async fn main<H: Hooks, M: MigratorTrait>() -> eyre::Result<()> { | |||
| }; | |||
|
|
|||
| let boot_result = create_app::<H, M>(start_mode, &environment).await?; | |||
| start(boot_result).await?; | |||
| let serve_config = ServeConfig { | |||
There was a problem hiding this comment.
maybe rename to ServeParams so we know it didn't come directly from config?
|
Nicely done @kaplanelad, I did not think about approaching it this way. Always something new to learn. I think what's left is to update loco docs so users can know how to use the newly added flags to manage their server address and port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.