-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prefix and route nesting to AppRoutes #1241
base: master
Are you sure you want to change the base?
Conversation
e40e529
to
348835f
Compare
@kaplanelad I am open to suggestions |
- replaced snapshot testing with normal asserts
5eea60a
to
b37e6d9
Compare
b37e6d9
to
08ba4ab
Compare
Finally fixed the ci It's now ready for review :) |
f1fb0a2
to
9468fe6
Compare
I think I fixed the doc test. I've added the If you want you can take a look here to see what attributes are available. |
No, this isn’t what we want—this was actually my original comment 🙂. |
The ignore feature has been removed: b4aa3f6. Also, I noticed that we don’t have documentation on AppRoutes. Could you please add it here?: https://loco.rs/docs/the-app/controller/ |
Added some docs |
replaced snapshot testing with normal asserts:
It was faster to replace snapshots with basic asserts then to look through multiple snapshot files with no relevant content.
Hope thats ok but I could revert it.
Closes: #1116