(docs) add explanation for fallback page #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplanelad
reviewed
Jan 22, 2025
| @@ -151,6 +151,8 @@ Now, run the Loco server again and you should see frontend app serving via Loco | |||
| $ cargo loco start | |||
| ``` | |||
|
|
|||
| If you see the default fallback page, you have to disable the fallback middleware. | |||
There was a problem hiding this comment.
I think it's not clear enough, I miss the reason.
There was a problem hiding this comment.
Good point, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some (hopefully) useful documentation for disabling the fallback page. As of version 0.14.0 the static handler does not take priority over the fallback handler, so the static handler is useless if the fallback is enabled. This relates to issue #1175
Please treat this PR as a suggestion and do with it what you will :)